-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34002/
-----------------------------------------------------------

(Updated May 21, 2015, 7:41 a.m.)


Review request for sentry, Colin Ma and Gregory Chanan.


Changes
-------

Refactored patch after initial review feedback.
The patch is to load hadoop configuration (core-site.xml) if it's there in 
classpath or via specified path as the Sentry resource configuration property.
The configuration object is cached in Sentry's hadoop group mapping provider to 
avoid reloading all the config files on every access.


Bugs: SENTRY-695
    https://issues.apache.org/jira/browse/SENTRY-695


Repository: sentry


Description
-------

Sentry service doesn't read default configuration resource. As a result any 
group mapping related properties (eg ldap properties etc) are not loaded from 
hadoop config files like core-site.xml. These properties have to be duplicated 
in sentry-site as well. When Sentry service is using underlying Hadoop group 
mapping, it should read the hadoop configuration which might include group 
mapping specific properties.

This patch is enabling Sentry's Hadoop Group mapping to load the hadoop 
configuration files if available. Also the group mapping service instance is 
Sentry is cached so that we don't have to instantiate it for every RPC request.


Diffs (updated)
-----

  
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/HadoopGroupMappingService.java
 14e2d05 

Diff: https://reviews.apache.org/r/34002/diff/


Testing
-------


Thanks,

Prasad Mujumdar

Reply via email to