----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31074/#review87993 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java <https://reviews.apache.org/r/31074/#comment140404> Seems like PRIVILIEGE1...8 is derrived from testPolicyImport.ini. Could it be possible to combine these two definitions together? In this case, when make change to the first place will automatically reflect to the file. It will be easier to maintain the code. - Anne Yu On June 2, 2015, 8:38 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31074/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 8:38 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryConfigTool for import/export feature > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 4388ca0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java > 7ebc0e4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImportExport.java > PRE-CREATION > sentry-tests/sentry-tests-hive/src/test/resources/testPolicyImport.ini > PRE-CREATION > sentry-tests/sentry-tests-hive/src/test/resources/testPolicyImportAdmin.ini > PRE-CREATION > sentry-tests/sentry-tests-hive/src/test/resources/testPolicyImportError.ini > PRE-CREATION > > Diff: https://reviews.apache.org/r/31074/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
