----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35549/#review88263 -----------------------------------------------------------
We should also document this change in the patch naming convention in our wiki. By default all patches are tested against the "master" branch. If your patch needs testing against a different branch please name your patch as "SENTRY-767.001-<branchname>.patch" dev-support/test-patch.py (line 91) <https://reviews.apache.org/r/35549/#comment140687> Can we keep this consistent with line <286> just to help code maintainability? "(/secure/attachment/\d+/%s[\w.-]*.(patch|txt|patch.txt))" % (re.escape(defect)) dev-support/test-patch.py (line 286) <https://reviews.apache.org/r/35549/#comment140689> - is * after (.\d+) required? - is + after (\w+) required? dev-support/test-patch.py (line 293) <https://reviews.apache.org/r/35549/#comment140690> We probably just default to master right, in which case Error can be misleading? - Sravya Tirukkovalur On June 17, 2015, 5:59 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35549/ > ----------------------------------------------------------- > > (Updated June 17, 2015, 5:59 a.m.) > > > Review request for sentry, Colin Ma, shen guoquan, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-767 > https://issues.apache.org/jira/browse/SENTRY-767 > > > Repository: sentry > > > Description > ------- > > The pre-commit run scripts are in sentry source repo, branch info should be > detected > > > Diffs > ----- > > dev-support/test-patch.py 7e701c3 > > Diff: https://reviews.apache.org/r/35549/diff/ > > > Testing > ------- > > Test in my local > > > Thanks, > > Dapeng Sun > >
