> On June 23, 2015, 10:52 a.m., Dapeng Sun wrote: > > Hi Prasad, I'm agree with this change. But I have a question: Since sentry > > clients are always bound with component services, I'm curious which scene > > don't have keytab file.
I have seen this in my testing with Impala client. In general it's better to cover that case to make Sentry RPC client more generic. > On June 23, 2015, 10:52 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java, > > line 249 > > <https://reviews.apache.org/r/35741/diff/1/?file=989910#file989910line249> > > > > Nit: It may be better to add some Unit Tests for it, or open a ticket > > to track it. Created SENTRY-782 to track new unit test case. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35741/#review88931 ----------------------------------------------------------- On June 22, 2015, 8:53 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35741/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 8:53 p.m.) > > > Review request for sentry, Dapeng Sun and Sravya Tirukkovalur. > > > Bugs: SENTRY-776 > https://issues.apache.org/jira/browse/SENTRY-776 > > > Repository: sentry > > > Description > ------- > > Currently the Sentry client requires principal/keytab for ZK connection. > Given that it's a common client for various downstream project, we should > also support ticket cache based connect to ZK. The patch supports both > options for creating JAAS context for secure ZK connection. The method can be > specified by a Sentry config property. > Also fixed the missing default for RPC address property resolving _HOST part > of the kerberos principal. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > 71935b1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/JaasConfiguration.java > d5f55fe > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 54dbac5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > 1b9691e > > Diff: https://reviews.apache.org/r/35741/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
