----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28227/#review91967 -----------------------------------------------------------
Overall looks good to me. @Dapeng, shall we also update the default versions to V2 in our request thrift structs? - Sravya Tirukkovalur On Nov. 19, 2014, 12:11 p.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28227/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:11 p.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-530 > https://issues.apache.org/jira/browse/SENTRY-530 > > > Repository: sentry > > > Description > ------- > > As discussed in SENTRY-390, we should check thirft version between client and > server. if the version mismatch, it should throw an exception. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/thrift/sentry_common_serviceConstants.java > 4fdeaeb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryThriftAPIMismatchException.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > c3dbf78 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 03ed378 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Status.java > c93dad5 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift > 9456274 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyStoreProcessor.java > ea4e967 > > Diff: https://reviews.apache.org/r/28227/diff/ > > > Testing > ------- > > UnitTests passed in local. > > > Thanks, > > Dapeng Sun > >
