----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36559/ -----------------------------------------------------------
Review request for sentry and Vamsee Yarlagadda. Repository: sentry Description ------- Sentry already has some audit log support, for example with the db provider. It would be nice to expand this to include the Solr Sentry request handlers. This just includes query/update/solr admin operations, i.e. it is independent of the service backend. Wolfgang Hoschek wrote the initial version of most of this code, I just adapted it to the sentry-solr module. Also, this patch includes the patch for SENTRY-805, because otherwise Reviewboard won't accept it. Diffs ----- sentry-solr/solr-sentry-handlers/pom.xml 7acdd40a5119c92b6ce944af407b9815cc27529b sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureDocumentAnalysisRequestHandler.java 23886feb9f5e834ba0d62c65049bd8d17390e973 sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureFieldAnalysisRequestHandler.java 4a8809afe8b357447046dbed84688763c49c9123 sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureReplicationHandler.java 70e5c83cd517e3376504f1dde43f44942bc1867f sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureRequestHandlerUtil.java 7ae5391a7f21368cf718d2f7c8b2790339864ac9 sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureAdminHandlers.java 54637549599c1afc3c6bccd1b5a7d3890f7867bd sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCollectionsHandler.java 0a471a4d289b7046f07b3a740271ed730330d2e0 sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCoreAdminHandler.java c1bde310e46e9dac7fa7814080e9b36c0d1dcd28 sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/component/QueryIndexAuthorizationComponent.java e4b5741b048f0a0a0202cdd7c95775e04f70b66f sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/sentry/AuditLogger.java PRE-CREATION sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/sentry/RollingFileWithoutDeleteAppender.java PRE-CREATION sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/sentry/SentryIndexAuthorizationSingleton.java 53c894635414923d2e1c269c958dacae225d4d32 sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/update/processor/UpdateIndexAuthorizationProcessor.java 8cd53d33af0148c2c7f76b20df0367a22a0fe42a sentry-solr/solr-sentry-handlers/src/main/resources/log4j.properties 62fdcd450a297cb6d5c967d9cf3229071dad45da sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/handler/admin/SecureCoreAdminHandlerTest.java 1857feb6622f72463f5c465698935b540116fa36 sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/sentry/SentryIndexAuthorizationSingletonTest.java 4bea2515c11a21308521583e074c738fd72f7bf9 sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/update/processor/UpdateIndexAuthorizationProcessorTest.java e2972324aa9b2643f42d561949913b4c7187ec9b Diff: https://reviews.apache.org/r/36559/diff/ Testing ------- Ran the sentry-solr unit tests. Thanks, Gregory Chanan
