> On July 27, 2015, 6:43 a.m., Dapeng Sun wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/HiveAuditMetadataLogEntity.java, > > line 109 > > <https://reviews.apache.org/r/36832/diff/1/?file=1022150#file1022150line109> > > > > If we return the new StringWriter, will the audit log still work? If > > not, we may need to throw the exception. > > Colin Ma wrote: > The code here is to process the problems when write the audit log, and > just output an empty audit log. I think the exception shouldn't be thrown > here and log the problem is ok, because the audit log's problem shouldn't > block the normal authorization process. > > Dapeng Sun wrote: > I don't sure what is the best practice, +0 about issue.
I'll fix it, thanks for the comments. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36832/#review93086 ----------------------------------------------------------- On July 28, 2015, 1:14 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36832/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 1:14 a.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Refactor the AuditMetadataLogEntity to support the audit log for generic mdoel > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/AuditMetadataLogEntity.java > 6b63045 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/entity/HiveAuditMetadataLogEntity.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestAuditMetadataLogEntity.java > 95b51e9 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/entity/TestHiveAuditMetadataLogEntity.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36832/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
