----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36997/#review93770 -----------------------------------------------------------
Ship it! Ship It! - Vamsee Yarlagadda On July 31, 2015, 7:28 p.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36997/ > ----------------------------------------------------------- > > (Updated July 31, 2015, 7:28 p.m.) > > > Review request for sentry and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > SENTRY-805 pulls the core name from NAME and tries to get the collection name > the standard way, i.e. by looking at the cloud descriptor. > > But this doesn't work if the core has not been created yet. > > Instead, we should build the core descriptor in the same way as the > CoreAdminHandler, see > https://github.com/apache/lucene-solr/blob/857bd14169db4683c29f4c8710ff9b96f5e9fe19/solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java#L551 > > > Diffs > ----- > > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCoreAdminHandler.java > 77548b95fdd9c196adada93ea0c8ff52b2ca7213 > > sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/handler/admin/SecureCoreAdminHandlerTest.java > 0dbb271431e312aeca2157a2e6c1509a3f424843 > > Diff: https://reviews.apache.org/r/36997/diff/ > > > Testing > ------- > > Ran the unit tests and verified on a cluster. > > > Thanks, > > Gregory Chanan > >
