----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37086/#review94090 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java (line 337) <https://reviews.apache.org/r/37086/#comment148585> What happens if either of the paths (old/new) are empty? Is that possible at all ? In either case: we should either handle it or atleast throw an error, as it might cause a nullpointer as well. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 938) <https://reviews.apache.org/r/37086/#comment148586> nit: space before catch - Sravya Tirukkovalur On Aug. 4, 2015, 5:13 p.m., Ryan Pridgeon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37086/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 5:13 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > SENTRY-780: HDFS Plugin should not execute path callbacks for views > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > 4924669 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > d75c578 > > Diff: https://reviews.apache.org/r/37086/diff/ > > > Testing > ------- > > Create, Drop, Create or Replace as Views with Sentry-Sync enabled. > > > Thanks, > > Ryan Pridgeon > >
