----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37044/#review94094 -----------------------------------------------------------
Ship it! LGTM, with a question to understand count. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java (line 158) <https://reviews.apache.org/r/37044/#comment148592> Question: user_role2 has select permissions on c1 and c2, wondering why select * succeeds while select count(*) fails; count(*) and count(1) require user to have at least table level permission? If user has select permission on all columns, is it the same as select permission on table? - Anne Yu On Aug. 3, 2015, 5:35 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37044/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 5:35 p.m.) > > > Review request for sentry, Anne Yu and Lenni Kuff. > > > Bugs: SENTRY-758 > https://issues.apache.org/jira/browse/SENTRY-758 > > > Repository: sentry > > > Description > ------- > > Also added tests for select *, select count(a), select count(*) for users > with different privileges > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java > 742c74fd66bfbda790c47a80f05fb8434b9a31da > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > f9e8f808ecf8da6001087fbc07e7d82d14be7f33 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java > 9eeed608abb92bf865cad22bec7a9b04a4709492 > > Diff: https://reviews.apache.org/r/37044/diff/ > > > Testing > ------- > > Added new tests > > > Thanks, > > Sravya Tirukkovalur > >
