> On July 28, 2015, 3:16 a.m., shen guoquan wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestAuditLogForSentryGenericService.java, > > line 61 > > <https://reviews.apache.org/r/36836/diff/1/?file=1022164#file1022164line61> > > > > When use BeforeClass and after not afterClass. It's weird. Can you used > > symmetric anntotations. Thanks.
TestAuditLogForSentryGenericService extends from SentryServiceIntegrationBase, the BeforeClass is used for initializing the logger appender to do the test, and the after is overrided to clear the environment using generic model(the default after is used for hive model). - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36836/#review93228 ----------------------------------------------------------- On July 27, 2015, 3:22 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36836/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 3:22 a.m.) > > > Review request for sentry, Dapeng Sun and shen guoquan. > > > Repository: sentry > > > Description > ------- > > Update processor for generic model to generate audit log > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > 62f36b4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java > 71ce579 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorWrapper.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestAuditLogForSentryGenericService.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/36836/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
