> On Aug. 14, 2015, 6:33 p.m., Sravya Tirukkovalur wrote: > > Can we setMetastoreListener = true for these updated tests, so that we can > > catch any further regressions in pre commit runs rather than real cluster > > runs? I see that there are more tests than covered on this jira which would > > fail if we make the default to true. > > https://issues.apache.org/jira/browse/SENTRY-830?focusedCommentId=14652573&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14652573 > > so we can probably set it to false just for these test classes which need > > more work and file a follow on jira.
Agreed! - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37469/#review95458 ----------------------------------------------------------- On Aug. 14, 2015, 4:42 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37469/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 4:42 a.m.) > > > Review request for sentry, Lenni Kuff and Sravya Tirukkovalur. > > > Bugs: SENTRY-850 > https://issues.apache.org/jira/browse/SENTRY-850 > > > Repository: sentry > > > Description > ------- > > Clean up more dbprovider test failures: run tests on a real cluster or > setMetastoreListener = true, if db/tab gets recreated their associated > privileges will be deleted. > > org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testAlterTableLocationPrivileges > org.apache.sentry.tests.e2e.dbprovider.TestColumnEndToEnd.testBasic > org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtDatabaseScope.testUseDbPrivilege > org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables3 > org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTablesExtended > org.apache.sentry.tests.e2e.dbprovider.TestDbRuntimeMetadataRetrieval.testShowTables1 > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegativeUserDMLPrivileges > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testNegUserPrivilegesAll > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt13 > org.apache.sentry.tests.e2e.dbprovider.TestDbSandboxOps.testSandboxOpt10 > org.apache.sentry.tests.e2e.dbprovider.TestDbUriPermissions.testLoadPrivileges > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java > 9ed38ae > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java > e1cda29 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java > 5324656 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java > e21dfe3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java > 43a310f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java > 7c9a66d > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java > c47686b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java > 626fd40 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java > 7c7c63e > > Diff: https://reviews.apache.org/r/37469/diff/ > > > Testing > ------- > > https://builds.apache.org/job/PreCommit-SENTRY-Build/781/console > > > Thanks, > > Anne Yu > >
