-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37794/#review96546
-----------------------------------------------------------



sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
 (line 122)
<https://reviews.apache.org/r/37794/#comment152012>

    Nit: typo



sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
 (line 734)
<https://reviews.apache.org/r/37794/#comment152010>

    Use ColumnMetaDataPrivilege from HiveAuthzPrivilegesMap?


- Sravya Tirukkovalur


On Aug. 26, 2015, 9:35 a.m., shen guoquan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37794/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2015, 9:35 a.m.)
> 
> 
> Review request for sentry, Colin Ma, Dapeng Sun, and Sravya Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> grant select(s) on table test_tb to role test_role;
> 
> show columns in test_tb;
> 
> Error: Error while compiling statement: FAILED: SemanticException No valid 
> privileges
>  Required privileges for this query: 
> Server=server1->Db=test_db->Table=test_tb->action=insert;Server=server1->Db=test_db->Table=test_tb->action=select;
>  (state=42000,code=40000)
> 
> It should show s column
> 
> 
> Diffs
> -----
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
>  PRE-CREATION 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
>  ddfb222 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivileges.java
>  8cd82ef 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java
>  0291b6c 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java
>  159b9d9 
> 
> Diff: https://reviews.apache.org/r/37794/diff/
> 
> 
> Testing
> -------
> 
> Run local unit case
> 
> 
> Thanks,
> 
> shen guoquan
> 
>

Reply via email to