----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38006/ -----------------------------------------------------------
Review request for sentry. Repository: sentry Description ------- SENTRY-841 Revoke on SERVER scope breaks Client API: There were actually two issues lumped into this one. The second, "allows any string to be passed in", is actually how the api was designed. We could try to fix that but this should be tracked as a separate issue. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 3c2c7c6 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java 4afe1b4 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 02c7535 Diff: https://reviews.apache.org/r/38006/diff/ Testing ------- There were actually two issues lumped into this one. The second, "allows any string to be passed in", is actually how the api was designed. We could try to fix that but this should be tracked as a separate issue. So the testing that was done with regard to the api was as follows: Attempt to revoke all from server without qualififying the explicit action; Assert that the privilege no longer exists; Thanks, Ryan Pridgeon
