----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35485/#review101968 -----------------------------------------------------------
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java (line 99) <https://reviews.apache.org/r/35485/#comment159480> SentryConfigurationException is for issues in the configuration of the service. I think we should just throw SentryAccessDeniedException with a proper message instead. What do you think? - Sravya Tirukkovalur On July 22, 2015, 1:54 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35485/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 1:54 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Make sure groups in list_sentry_privileges_for_provider is not empty > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java > 0622b43 > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrAuthzBinding.java > c37f8ff > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java > a88d2f8 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java > ddb9cf9 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > 06573b7 > > sentry-solr/solr-sentry-handlers/src/main/resources/sentry-handlers/sentry/test-authz-provider.ini > 8f48a8c > > sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/sentry/SentryIndexAuthorizationSingletonTest.java > a3d7d19 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > fa34c33 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java > 30041c5 > > sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini > 34a030d > > Diff: https://reviews.apache.org/r/35485/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
