Picking this back up since it would be good to settle on a updated style guide soon. It sounds like we are in agreement that the Hadoop style guide is one that would work well for Sentry. I'll post this as an official vote on the dev list and we can move to the new style if the vote passes. .
On Tue, Aug 25, 2015 at 6:19 PM, Sun, Dapeng <[email protected]> wrote: > +1 We can also use "maven-checkstyle-plugin" to check the code > automatically. > > Regards > Dapeng > > -----Original Message----- > From: Lenni Kuff [mailto:[email protected]] > Sent: Wednesday, August 26, 2015 9:07 AM > To: [email protected] > Subject: Re: sentry code style > > +1 - The Hadoop project seems like a good place to pull from. > > On Tue, Aug 25, 2015 at 5:52 PM, Sravya Tirukkovalur <[email protected]> > wrote: > > > +1. I think it would be very useful to have a coding convention doc > > +and a > > review check list as in Hadoop. I have not read through it completely > > yet, but I would suggest adopting it from Hadoop (removing some items > > which might not be relevant for Sentry). > > > > On Tue, Aug 25, 2015 at 5:37 PM, Li Li <[email protected]> wrote: > > > > > Hey, guys, > > > > > > Since I haven't found the code style document in Sentry website > > > <https://sentry.incubator.apache.org/>, I wonder if we have any > > > standard code style for Sentry. If not, shall we create one? Maybe > > > we can start from Sun's Java coding conventions > > > <http://www.oracle.com/technetwork/java/codeconvtoc-136057.html> > > > which > > is > > > followed by most of the Apache java projects, like hadoop > > > <https://wiki.apache.org/hadoop/CodeReviewChecklist>, apache commons > > > <https://commons.apache.org/proper/commons-net/code-standards.html>, > > hive > > > < > > > > > https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowTo > > Contribute-CodingConventions > > > > > > > , cassandra <http://wiki.apache.org/cassandra/CodeStyle>, avro > > > <https://cwiki.apache.org/confluence/display/AVRO/Code+Review+Checkl > > > ist> > > > and > > > so on. > > > > > > Thanks, > > > Li > > > > > > > > > > > -- > > Sravya Tirukkovalur > > >
