----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39116/#review103467 -----------------------------------------------------------
Ship it! sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java (lines 90 - 94) <https://reviews.apache.org/r/39116/#comment161531> Nit: Assigning default size to a local vriable makes this code block more readable? - Sravya Tirukkovalur On Oct. 12, 2015, 6:15 a.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39116/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 6:15 a.m.) > > > Review request for sentry, Anne Yu, Lenni Kuff, and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Set max message size for thrift messages > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/SentryHDFSServiceClientDefaultImpl.java > c727403a246970f92156a36255b764d5dfe3df03 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java > 19b0b49a14649f8da7ab5e00e38216e3ba9c15e2 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ThriftSerializer.java > b5857735c2fcbb31484aa954b73ecc3a32cbba98 > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestHMSPathsFullDump.java > f74a75dd94192aaa2ab36cce40e8ada6807cedcf > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > 67a3574d180ceef2a766920bf2a0ab1ebfd9092f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > ae0eec224a956189512deb77c8de235436ed627d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 1af7a8b4739aa00d2f28d92b9388e0b1c565c227 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > bc357421974452d3977380e1a6327cc6e6d6ca06 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithInvalidMsgSize.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39116/diff/ > > > Testing > ------- > > > Thanks, > > Li Li > >
