----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34756/#review103665 -----------------------------------------------------------
Ship it! sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java (line 235) <https://reviews.apache.org/r/34756/#comment161730> Can you please comment on the jira that we have a test case here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java (line 290) <https://reviews.apache.org/r/34756/#comment161731> Fix the jira number. 717 seems like is unrelated? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 622) <https://reviews.apache.org/r/34756/#comment161727> Nit: Rename it to exec instead? execQuery usually corresponds to a call which returns resultset. - Sravya Tirukkovalur On Oct. 22, 2015, 7:43 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34756/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 7:43 p.m.) > > > Review request for sentry, Li Li, Lenni Kuff, and Sravya Tirukkovalur. > > > Bugs: SENTRY-748 > https://issues.apache.org/jira/browse/SENTRY-748 > > > Repository: sentry > > > Description > ------- > > Add new test case to validate complex view privilege: view by union tables, > view from another view, view with subquery and view by joining tables; > > Resent the cr. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml 7744da1 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbComplexView.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > cc5daef > > Diff: https://reviews.apache.org/r/34756/diff/ > > > Testing > ------- > > https://builds.apache.org/job/PreCommit-SENTRY-Build/608/, seems like tests > all passed now. > > > Thanks, > > Anne Yu > >
