+1, We have notice Solr Unit Tests failed: https://issues.apache.org/jira/browse/SENTRY-397 Sentry also support HDFS, HIVE and SQOOP, I found all of them also already upgraded to JDK 1.7, it may be the time to upgrade the Sentry JDK version.
Hi Colm, You can file a jira to upgrade JDK version in pom.xml and upload a patch if you like, I can help review the patch. https://cwiki.apache.org/confluence/display/SENTRY/How+to+Contribute Regards Dapeng -----Original Message----- From: Anne Yu [mailto:[email protected]] Sent: Wednesday, November 04, 2015 3:12 AM To: Colm O hEigeartaigh Cc: [email protected] Subject: Re: JDK6 compatibility +1. Could you file a jira also? Thanks, Anne On Tue, Nov 3, 2015 at 7:13 AM, Colm O hEigeartaigh <[email protected]> wrote: > > Unless there is a compelling reason to keep JDK 6 compatibility, I > would recommend moving to a minimum of JDK 7. The current source > compiles, with some trivial changes, with JDK 6, but a whole load of > tests don't work due to dependencies that don't support JDK 6 anymore. > For example, the hive tests have a dependency on libthrift 0.9.2 that > doesn't support JDK6, the solr tests also require JDK 7. > > Colm. > > On Tue, Oct 27, 2015 at 5:11 PM, Anne Yu <[email protected]> wrote: > >> It seems jdk1.6 upgrade is still a separate issue, even if we turn >> off tests for now; >> >> If you want to upgrade to jdk1.6, could you do a local compile, run >> unit tests, then also start sentry service with Hive, see if it works >> fine? Test is necessary to ensure compiler change. >> >> If other folks happen to know the history / results, could also post >> more information here. >> >> Best, >> Anne >> >> On Tue, Oct 27, 2015 at 8:12 AM, Colm O hEigeartaigh >> <[email protected] >> > wrote: >> >>> Thanks for the feedback. Before filing the bug though, I'd like to >>> know whether it is a requirement that Sentry supports JDK 1.6 or >>> not? If yes I will try to supply a patch to exclude the failing >>> tests, otherwise update the compiler plugin to 1.7. >>> >>> Colm. >>> >>> On Tue, Oct 27, 2015 at 3:07 PM, Anne Yu <[email protected]> wrote: >>> >>>> Hey Colm, >>>> >>>> You can file a bug to state the problem. And if no one is picking >>>> up the issue, you can assign to yourself then request a code review. >>>> >>>> Best, >>>> Anne >>>> On Oct 27, 2015 7:26 AM, "Colm O hEigeartaigh" >>>> <[email protected]> >>>> wrote: >>>> >>>>> Hello, >>>>> >>>>> I see that the source code is still enforced to be 1.6 via the >>>>> maven compiler plugin. However, there are a bunch of tests that >>>>> fail due to >>>>> 1.7 >>>>> dependencies, e.g.: >>>>> >>>>> testInitializer(org.apache.sentry.hdfs.TestMetastoreCacheInitializ >>>>> er) >>>>> Time >>>>> elapsed: 0.247 sec <<< ERROR! >>>>> java.lang.UnsupportedClassVersionError: >>>>> com/facebook/fb303/FacebookService$Iface : Unsupported major.minor >>>>> version >>>>> 51.0 >>>>> >>>>> >>>>> testExceptionInTask(org.apache.sentry.hdfs.TestMetastoreCacheIniti >>>>> alizer) Time elapsed: 0.003 sec <<< ERROR! >>>>> java.lang.UnsupportedClassVersionError: >>>>> org/apache/hadoop/hive/metastore/IHMSHandler >>>>> >>>>> etc. Perhaps it's time to move the maven.compile.source/target >>>>> properties in the pom to 1.7? >>>>> >>>>> Colm. >>>>> >>>>> >>>>> -- >>>>> Colm O hEigeartaigh >>>>> >>>>> Talend Community Coder >>>>> http://coders.talend.com >>>>> >>>> >>> >>> >>> -- >>> Colm O hEigeartaigh >>> >>> Talend Community Coder >>> http://coders.talend.com >>> >> >> >> >> -- >> Thanks, >> Anne >> > > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- Thanks, Anne
