> On Nov. 6, 2015, 5:55 p.m., Sravya Tirukkovalur wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryAuthorizationProvider.java, > > line 202 > > <https://reviews.apache.org/r/39928/diff/2/?file=1117508#file1117508line202> > > > > Should this be /user/authz/xxx (in prefix but not a hive object)? Looks > > like you already tested for /user/authz/obj (in prefix and hive object)?
Yeah, I am testing inside prefix and is a hive object. Will change the comment correspondingly. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39928/#review105476 ----------------------------------------------------------- On Nov. 6, 2015, 1:29 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39928/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 1:29 a.m.) > > > Review request for sentry, Anne Yu, Lenni Kuff, and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Change-Id: I7c65bf182c44075f41de16943c5b7eb66e3dec0b > > SENTRY-994: Changed the Logger level and added more test case for > removeACLFeature. > > Change-Id: I851344e088155e28c8978203759fe56884b29e41 > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java > 419ab68e0d03f995c55d229b762453468de47571 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryAuthorizationProvider.java > fd5146f079d93687738a522f42beaa59031a4f82 > > Diff: https://reviews.apache.org/r/39928/diff/ > > > Testing > ------- > > Added several new unit tests for setPermission/setUser/setGroup/removeAcl > cases validation. > > > Thanks, > > Hao Hao > >
