> On Nov. 6, 2015, 11:32 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java, > > lines 320-327 > > <https://reviews.apache.org/r/40038/diff/1/?file=1118450#file1118450line320> > > > > Since similar code are used across the test cases, can those lines be > > refactor to a private API?
Makes sense. Adding a static helper which creates sessions and cleans them up. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40038/#review105523 ----------------------------------------------------------- On Nov. 6, 2015, 8:24 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40038/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 8:24 p.m.) > > > Review request for sentry, Anne Yu, Hao Hao, and Lenni Kuff. > > > Bugs: SENTRY-955 > https://issues.apache.org/jira/browse/SENTRY-955 > > > Repository: sentry > > > Description > ------- > > Add more meta data operation tests for column level privilege > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java > fba883c32c7e52aa6ea6584b278980fe5ab262a8 > > Diff: https://reviews.apache.org/r/40038/diff/ > > > Testing > ------- > > Added new tests and ran them. > > > Thanks, > > Sravya Tirukkovalur > >
