+1 to initialization being atomic. And I guess throwing an initialization exception after multiple retries should be fine. Still want to hear if any one thinks logging an error is preferable.
On Mon, Nov 9, 2015 at 2:40 PM, Ryan P <[email protected]> wrote: > So I would definitely suggest thay the metastore cache initialization phase > be atomic. That being said we should introduce some sort of retry logic. In > the event we can't complete a task we throw an initialization exception. > On Nov 9, 2015 4:18 PM, "Sravya Tirukkovalur" <[email protected]> wrote: > > > Hi folks, > > > > Right now if there is an error condition in evaluating paths > > in MetaStoreCacheIntilizer in one of the tasks, we throw a Runtime > > Exception. The more I think about, it looks like it would be best to log > an > > error and continue; as a plugin should not cause the service to come > down? > > On the other hand, doing so might result in incomplete sync which might > > make it hard to get to the root cause. > > > > Tracking this at https://issues.apache.org/jira/browse/SENTRY-957 > > > > Please let me know your thoughts. > > > > Thanks! > > -- > > Sravya Tirukkovalur > > >
