----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40239/#review106319 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 1122) <https://reviews.apache.org/r/40239/#comment165052> Did you get a chance to run the e2e test you added? I applied your pacth and encountered serveral issues. - Hao Hao On Nov. 12, 2015, 5:42 p.m., Ryan Pridgeon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40239/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 5:42 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > SENTRY-954: removeAclFeature/addAclFeature should only affect dirs under a > prefix which is managed. I did attempt to clean up SentryAuthorizatinProvider > a bit as well which may be a no no. Should be easy to revert these changes > without too much hassle > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java > 4d03ba3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 208c93b > > Diff: https://reviews.apache.org/r/40239/diff/ > > > Testing > ------- > > Added testing to TestSentryAuthorizationProvider.java > > > Thanks, > > Ryan Pridgeon > >
