----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40615/#review107660 -----------------------------------------------------------
sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java (line 56) <https://reviews.apache.org/r/40615/#comment166897> Seems RetryStrategy could be located inside BaseTask. sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java (line 72) <https://reviews.apache.org/r/40615/#comment166893> Not very clear the logic behind this api: maybe you want to do stopRetry? sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java (line 125) <https://reviews.apache.org/r/40615/#comment166895> Is InterruptedException the only type of exception to stop retry? sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java (line 326) <https://reviews.apache.org/r/40615/#comment166888> White spaces. sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java (line 327) <https://reviews.apache.org/r/40615/#comment166898> callResult might need a boolean value to hold retry status, then pass on to failOnRetry; failOnRetry doesn't need to be assigned as a constant value. - Anne Yu On Nov. 23, 2015, 10:17 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40615/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 10:17 p.m.) > > > Review request for sentry, Anne Yu, Lenni Kuff, and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Change-Id: I3f9e2e1f17e8ff6d336ca748d2be763cc767bd72 > > Retries the failed task with configurable times. Each retry waits for a > configurable time. > Client can configure whether to fail the startup (atomic) or continue with > partial paths with log errors available. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java > 19b0b49a14649f8da7ab5e00e38216e3ba9c15e2 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java > eb85d45d9401cfa25b01bf70b860c9d3d940dd52 > > sentry-hdfs/sentry-hdfs-service/src/test/java/org/apache/sentry/hdfs/TestMetastoreCacheInitializer.java > f1e729ff9fd94cfbcd9d0ba89d850b665e681904 > > Diff: https://reviews.apache.org/r/40615/diff/ > > > Testing > ------- > > Tested on TestMetastoreCacheInitializer. > > > Thanks, > > Hao Hao > >
