----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41478/#review111530 -----------------------------------------------------------
Ship it! Ship It! - Vamsee Yarlagadda On Dec. 17, 2015, 12:01 a.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41478/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 12:01 a.m.) > > > Review request for sentry and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Pretty straightforward, moved the following files from solr-sentry-handlers > to solr-sentry-core since they aren't really handler related and it makes > supporting multiple solr versions cleaner: > AuditLogger > RollingFileWithDeleteAppender > SecureRequestHandlerUtil > SentryIndexAuthorizationSingleton > > > Diffs > ----- > > pom.xml 9495286cbf3b691ccd6f4b2120553c64d46c7323 > sentry-dist/pom.xml daa2a5a9374dbcb699bef9775aa1549b3de0428a > sentry-solr/pom.xml c3e22c4ae6267194ca751677e63647a7e001485e > sentry-solr/solr-sentry-core/pom.xml PRE-CREATION > > sentry-solr/solr-sentry-core/src/main/java/org/apache/solr/sentry/AuditLogger.java > PRE-CREATION > > sentry-solr/solr-sentry-core/src/main/java/org/apache/solr/sentry/RollingFileWithoutDeleteAppender.java > PRE-CREATION > > sentry-solr/solr-sentry-core/src/main/java/org/apache/solr/sentry/SecureRequestHandlerUtil.java > PRE-CREATION > > sentry-solr/solr-sentry-core/src/main/java/org/apache/solr/sentry/SentryIndexAuthorizationSingleton.java > PRE-CREATION > sentry-solr/solr-sentry-handlers/pom.xml > 61c2da24f16468a521eddb86fd6f7c35dd12da12 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureDocumentAnalysisRequestHandler.java > 9ecf1398ea71d02ed116ca51bca3773f3410f248 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureFieldAnalysisRequestHandler.java > 819227bcf43032dc0963ff804483a0c892e47775 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureReplicationHandler.java > 42213ae2499d033458c369427a68265e98d24033 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureRequestHandlerUtil.java > 94341b3b3d8a50fbeab72f3236866f88e34bd849 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureAdminHandlers.java > 88016eaebbecea5991cdaa94d49c55b4d5051616 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCollectionsHandler.java > 15a6ba08a235d5b6e2cc47183e7e99d70fe02213 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCoreAdminHandler.java > 57ccc9493d8cf179b621b992ccddbcf10c7bbf9f > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/sentry/AuditLogger.java > 7f3e391e1f7b5a4e4e836639b3ad8b792d1f57d4 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/sentry/RollingFileWithoutDeleteAppender.java > ec26ef3220676285289b98aa833a1da666b706e7 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/sentry/SentryIndexAuthorizationSingleton.java > 185884b9ccc1753083522d940455007d4cdcab12 > > sentry-solr/solr-sentry-handlers/src/test/java/org/apache/solr/sentry/SentrySingletonTestInstance.java > ae024667df80d8a7d5cb24acb51b5f42949de112 > > Diff: https://reviews.apache.org/r/41478/diff/ > > > Testing > ------- > > Unit tests passed successfully locally. > > > Thanks, > > Gregory Chanan > >
