-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41662/#review113641
-----------------------------------------------------------

Ship it!


Ship It!

- Lenni Kuff


On Jan. 9, 2016, 3:31 p.m., Li Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41662/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2016, 3:31 p.m.)
> 
> 
> Review request for sentry, Anne Yu, Hao Hao, Lenni Kuff, and Sravya 
> Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> The SemanticException happened in HiveAuthzBinding.authorize method, which is 
> caused by the empty outputHierarchy list. As there is no partition in the 
> test tbl, the writeEntity set returned from Hive is empty. That's why the 
> outputHierarchy list is also empty. To resolve it, we should manually add 
> db.tbl in the outputHierarchy which will be validated in the 
> hiveAuthzBinding.authorize method.
> 
> 
> Diffs
> -----
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
>  994af8a04414f5093a0d5546744d6da727b69db4 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java
>  56776db7c463e1f27cd39baa9e4c9d9709c53925 
> 
> Diff: https://reviews.apache.org/r/41662/diff/
> 
> 
> Testing
> -------
> 
> add test case for:
> empty partitioned table and NOT empty partitioned table
> user with permission and user WITHOUT permission
> 
> 
> Thanks,
> 
> Li Li
> 
>

Reply via email to