----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42364/#review114801 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java <https://reviews.apache.org/r/42364/#comment175653> Will put it back. Was testing sth but forgot to revert. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 501) <https://reviews.apache.org/r/42364/#comment175654> Will remove the first close statement. - Anne Yu On Jan. 15, 2016, 10:44 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42364/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 10:44 p.m.) > > > Review request for sentry and Hao Hao. > > > Bugs: SENTRY-1009 > https://issues.apache.org/jira/browse/SENTRY-1009 > > > Repository: sentry > > > Description > ------- > > We started to see many TestDatabaseProvider test failures because it > validates number of test objects instead of test object names. Because there > are some system roles created in the environment, so the number of objects > are usually larger than expected. Improved the test cases. Also catch the > exception whenever cleanup fails since we don't need to do anything. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 98de57d3d749c3f887632ff1461ef05dd29376c1 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > dc8c1eb802adbf198e8623b02bd77bb8aff7fa41 > > Diff: https://reviews.apache.org/r/42364/diff/ > > > Testing > ------- > > mvn test -Dtest=TestDatabaseProvider passed locally testing enviroments. > > > Thanks, > > Anne Yu > >
