----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42385/#review114847 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java (line 120) <https://reviews.apache.org/r/42385/#comment175693> Should we log a debug message saying that we skipped the event because the operation did not succeed? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 951) <https://reviews.apache.org/r/42385/#comment175692> Also add tests for create partition failure, and drop table/partition? Not sure how easy those are to test. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 954) <https://reviews.apache.org/r/42385/#comment175690> Maybe check if path exists prior to creation and remove it if it already exists? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java (line 980) <https://reviews.apache.org/r/42385/#comment175691> Add a comment on why you expect this to fail. Also add an "assertFalse()" immediately after the stmt.execute to ensure that the creation actually fails. - Lenni Kuff On Jan. 16, 2016, 3:22 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42385/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2016, 3:22 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Change-Id: Ia054eab294d712641ea9e6dc58521d41c2e65ef9 > > Sentry plugin for hdfs path sync is not handling the error case properly. > When even such as createTable is not successful, the path should not be > updated to Sentry server. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > 3c8ad1f6787623bf95d0ba53de9eb09223f9999b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 5a93ba0108bbe542e8a294ef43b96fa0c718eda5 > > Diff: https://reviews.apache.org/r/42385/diff/ > > > Testing > ------- > > Added e2e test TestHDFSIntegration.testCreationTableFailure. > > > Thanks, > > Hao Hao > >
