> On Jan. 16, 2016, 8:15 a.m., Lenni Kuff wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java, > > line 605 > > <https://reviews.apache.org/r/42344/diff/2/?file=1198197#file1198197line605> > > > > Why not just always get a cache binding? How much does this improve > > things versus the previous approach?
Agree with Lenni, and we should have a performance test to check the performance impact if always get a cache binding. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42344/#review114850 ----------------------------------------------------------- On Jan. 15, 2016, 11:47 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42344/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2016, 11:47 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1007 > https://issues.apache.org/jira/browse/SENTRY-1007 > > > Repository: sentry > > > Description > ------- > > Since current architecture will do one time authorization for every entity, > the sql script like **select col1,col2,col3,.....,colN from test_tb1** will > authorize all the query columns. > > This patch will reuse the CachedHiveBinding at SENTRY-565. > If entity > maxQueryNumber, it will query all user's privileges to local, and > use the local privilege for authorzation. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 57e4689 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > e76fad1 > > Diff: https://reviews.apache.org/r/42344/diff/ > > > Testing > ------- > > > Thanks, > > Dapeng Sun > >
