----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42577/#review115572 -----------------------------------------------------------
Ship it! sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryPermissions.java (line 25) <https://reviews.apache.org/r/42577/#comment176562> Add brief class comment on what this test suite is targeting. sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryPermissions.java (line 34) <https://reviews.apache.org/r/42577/#comment176561> As sanity check, add another check: Assert.assertNull(perm.getRoleInfo("doesNotExist")); - Lenni Kuff On Jan. 20, 2016, 11:51 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42577/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 11:51 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Change-Id: I4030f433df33a67137cb5125daf1068516ac0e49 > The RoleInfo of Sentry Permission should be case insensitive. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > daa87cf8b629449f2abfa2ca0611c70be16aded1 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryPermissions.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42577/diff/ > > > Testing > ------- > > Added unit test TestSentryPermissions.testRoleInfoCaseInsensitive > > > Thanks, > > Hao Hao > >
