> On Jan. 21, 2016, 4:49 a.m., Anne Yu wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithHiveServer.java, > > line 24 > > <https://reviews.apache.org/r/42583/diff/1/?file=1204142#file1204142line24> > > > > Just wondering do you notice any slowing down when you run all the > > tests locally? It seems hiveserver instance gets teared down for each test > > case instead of test class. > > > > Also why move tear town to method level will resolve the exception > > issue?
Did not see any noticeable slowing down on my locally tests. The exception is caused by hive server being created again in the test (such as in function verifyInvalidConfigurationException) before shutting down. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42583/#review115561 ----------------------------------------------------------- On Jan. 21, 2016, 2:29 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42583/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 2:29 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Change-Id: I16cbeb90b979bb1d25fd42adfe6a6aaf2ecb34f6 > HiveServer needs to be properly shutdown. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithHiveServer.java > 56ed955ed5ffca7332a5d1d824f19c3425c2af7c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestServerConfiguration.java > 18fc5d922553ffbe1da4acb7c34508d390994c06 > > Diff: https://reviews.apache.org/r/42583/diff/ > > > Testing > ------- > > Tests done in TestServerConfiguration. > > > Thanks, > > Hao Hao > >
