-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42682/
-----------------------------------------------------------
(Updated Jan. 25, 2016, 7:01 p.m.)
Review request for sentry.
Changes
-------
Small updates for pmd.
Repository: sentry
Description
-------
Here is a solr shell, based on the existing hive shell. Actually most of the
work is specific to the generic model, there is only a small amount of
solr-specific code. So it should be easily extensible for other clients.
Some limitations:
It is not integrated with bin/sentryShell yet
It does not support any grant options
It is pretty restrictive in what it supports, i.e. it checks for know
authorizables and throws an exception if it doesn't know about any. So it can't
be used for anything outside of collection permissions.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/pom.xml
7514a7cdfcc7934f2dd0386996fdaf88c0ccbb14
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellSolr.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SolrTSentryPrivilegeConvertor.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/Command.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/CreateRoleCmd.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/DropRoleCmd.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/GrantPrivilegeToRoleCmd.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/ListPrivilegesByRoleCmd.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/ListRolesCmd.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/RevokePrivilegeFromRoleCmd.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/generic/TSentryPrivilegeConvertor.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellSolr.java
PRE-CREATION
Diff: https://reviews.apache.org/r/42682/diff/
Testing
-------
Ran the unit tests.
Thanks,
Gregory Chanan
