> On Jan. 27, 2016, 7:44 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/pom.xml, lines 103-106 > > <https://reviews.apache.org/r/42682/diff/6/?file=1221775#file1221775line103> > > > > Why do we need solr policy dependency here? > > Gregory Chanan wrote: > This and the question below are good questions. So far I just followed > the structure of the hive stuff, which arguably doesn't belong in here either > (you could make an argument that the old model only supported hive, so maybe > it's okay). > > I think we should take up how we structure these things in general in > another issue. For one, I don't think any of the shell stuff really belongs > in the provider-db...the provider is for the services and the services are > never going to use a cli. And the "db" always confuses me -- is that > referring to the db model or the db-backed sentry service? In any case, I'm > arguing that we should figure out a plan in general for how external services > are structured. Right now for solr we have: > binding > sentry-solr (this could probably be combined with the binding?) > shell > > Where should these all live? I think that's a complex question worthy of > a seperate topic.
db here refers to db-backed sentry. Yes, ideally we should only have sentry service and client to talk to service in provider-db, we should also consider renaming it when we deprecate file based sentry. And we should not have any external service specific stuff in here, not even hive. Lets file a follow on jira. We should brainstorm some ideas, clearing this up would also help future integrations. Another thing we should think about is making the solrshell a generic shell and provide a generic validation which uses the model on the fly. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42682/#review116451 ----------------------------------------------------------- On Jan. 26, 2016, 8:11 p.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42682/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 8:11 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Here is a solr shell, based on the existing hive shell. Actually most of the > work is specific to the generic model, there is only a small amount of > solr-specific code. So it should be easily extensible for other clients. > > Some limitations: > > It is not integrated with bin/sentryShell yet > It does not support any grant options > It is pretty restrictive in what it supports, i.e. it checks for know > authorizables and throws an exception if it doesn't know about any. So it > can't be used for anything outside of collection permissions. > > > Diffs > ----- > > sentry-provider/sentry-provider-db/pom.xml > 7514a7cdfcc7934f2dd0386996fdaf88c0ccbb14 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/Command.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/CreateRoleCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/DropRoleCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/GrantPrivilegeToRoleCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/ListPrivilegesByRoleCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/ListRolesCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/RevokePrivilegeFromRoleCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/TSentryPrivilegeConvertor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java > b1353c5312e9d53b6dd184edd1fa8c11a92b4374 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceIntegrationBase.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java > 4732ea2fcac1f9cb6a885592378f7916edbde3a1 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42682/diff/ > > > Testing > ------- > > Ran the unit tests. > > > Thanks, > > Gregory Chanan > >
