----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42867/#review116733 -----------------------------------------------------------
Ship it! - Lenni Kuff On Jan. 28, 2016, 7:15 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42867/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 7:15 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Change-Id: I9976086dbdf3c57c931d729870eeeaa6f7e6fa29 > There a few edge cases where Paths update may be passed a path which lacks a > URI Scheme. > i.e /user/hive/warehouse > In this situation PathsUpdate will throw an uncaught NPE at the Precondition > check. > Use the default scheme of the filesystem and silently ignore other schemeless > paths. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > 1dcb75a3dc7735e11289ab75424199ab1a086ce2 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > fc7f3245a274a60d811fdbbe10119ad54fa687cd > > Diff: https://reviews.apache.org/r/42867/diff/ > > > Testing > ------- > > Test done in TestHDFSIntegration.testMissingScheme. > > > Thanks, > > Hao Hao > >
