> On Jan. 26, 2016, 7:31 a.m., Lenni Kuff wrote:
> > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Host.java,
> > line 20
> > <https://reviews.apache.org/r/42568/diff/3/?file=1204711#file1204711line20>
> >
> > Are these object names expected to be case insensitive? Should comment
> > on that someplace.
Not sure what you mean by case insensitive object names. Do you mean the values
of these objects? Say, Host("host1") == Host("Host1")? If that is the actual
question, values are case sensitive.
> On Jan. 26, 2016, 7:31 a.m., Lenni Kuff wrote:
> > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionConstant.java,
> > line 22
> > <https://reviews.apache.org/r/42568/diff/3/?file=1204712#file1204712line22>
> >
> > Do you support "ALL_NAME"?
Yes. Actually we do not support "*" for operations. Removed.
> On Jan. 26, 2016, 7:31 a.m., Lenni Kuff wrote:
> > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionFactory.java,
> > line 24
> > <https://reviews.apache.org/r/42568/diff/3/?file=1204713#file1204713line24>
> >
> > Seems like this should be a singleton class (or even better, just have
> > static methods to create actions - but that might require some refactoring).
Refactored it to be a singleton.
> On Jan. 26, 2016, 7:31 a.m., Lenni Kuff wrote:
> > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionFactory.java,
> > line 98
> > <https://reviews.apache.org/r/42568/diff/3/?file=1204713#file1204713line98>
> >
> > clarify
Not required. Thanks for pointing to this.
> On Jan. 26, 2016, 7:31 a.m., Lenni Kuff wrote:
> > sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionFactory.java,
> > line 27
> > <https://reviews.apache.org/r/42568/diff/3/?file=1204713#file1204713line27>
> >
> > Would it be better to just do something like:
> >
> > READ(new KafkaAction(KafkaActionConstant.READ, 1));
> >
> >
> > Then you don't have to create a new instance of KafkaAction and match
> > the names with each call.
I might be missing something, but I do not think that is happening even now.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42568/#review116297
-----------------------------------------------------------
On Jan. 21, 2016, 10:29 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42568/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 10:29 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1012
> https://issues.apache.org/jira/browse/SENTRY-1012
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1012: Add core model for Kafka
>
>
> Diffs
> -----
>
> pom.xml 6210454e87dc1fd3e6fc4abe10e42cf7b02591aa
> sentry-core/pom.xml 59d32c4da0a6de77510d142efd006c345628c4a5
> sentry-core/sentry-core-model-kafka/pom.xml PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Cluster.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/ConsumerGroup.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Host.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionConstant.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaActionFactory.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/KafkaAuthorizable.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Topic.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/test/java/org/apache/sentry/core/model/kafka/TestKafkaAction.java
> PRE-CREATION
>
> sentry-core/sentry-core-model-kafka/src/test/java/org/apache/sentry/core/model/kafka/TestKafkaAuthorizable.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/42568/diff/
>
>
> Testing
> -------
>
> Added unit tests. Also covered via end-to-end tests as part of SENTRY-1014.
>
>
> Thanks,
>
> Ashish Singh
>
>
