----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43078/#review117354 -----------------------------------------------------------
Ship it! Ship It! - Colin Ma On Feb. 2, 2016, 12:54 a.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43078/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 12:54 a.m.) > > > Review request for sentry, Colin Ma and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > This has a couple of solr client improvements: > 1) Fixes an error message and properly exits non-0 if an exception occurs > 2) CLient verifies whether a privilege contains an action, which is a better > user experience than getting back a thrift exception. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java > 15f4a26e8fbf41ee6ffbdf9644e9d50ad4e74c77 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java > b636b4c0d57b2ba28d69507acdd336bc11a0d84a > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java > 354cf357dd3f74696de4d3eb49d707e980a1a641 > > Diff: https://reviews.apache.org/r/43078/diff/ > > > Testing > ------- > > Ran the unit tests. > > > Thanks, > > Gregory Chanan > >
