----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43130/ -----------------------------------------------------------
Review request for sentry, Colin Ma, Lenni Kuff, and Sravya Tirukkovalur. Repository: sentry Description ------- Right now, following the pattern of the Hive shell, the Solr shell manually implements validators, i.e.: https://github.com/apache/incubator-sentry/blob/597a3cdd319be84f2417c96d24db01553f264551/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java#L115-L130 It would be better if we automatically used the existing validators, so they don't need to be implemented in multiple places. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java e2b01a45a32d9f60a6f2d596e5149ca4a8d0188c Diff: https://reviews.apache.org/r/43130/diff/ Testing ------- Ran unit tests. Thanks, Gregory Chanan
