----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43185/#review118052 -----------------------------------------------------------
Thanks for consolidating it Colm! Change looks good to me. One improvement: I was wondering as most of our integrations do use default implementation, it might be worth providing a DefaultPrivilege (instead of requiring each integration to subclass this abstract class?) sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/AbstractPrivilege.java (line 32) <https://reviews.apache.org/r/43185/#comment179321> While you are here, may be comment on what these parameters mean? - Sravya Tirukkovalur On Feb. 4, 2016, noon, Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43185/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, noon) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > The policy Privilege implementations could be consolidated > > > Diffs > ----- > > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/AbstractPrivilege.java > PRE-CREATION > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPrivilege.java > 116e0aa > > sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerWildcardPrivilege.java > 0ec0ce1 > > sentry-policy/sentry-policy-search/src/main/java/org/apache/sentry/policy/search/SearchWildcardPrivilege.java > e25faf2 > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java > ae89cf4 > > Diff: https://reviews.apache.org/r/43185/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
