----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43242/#review118508 -----------------------------------------------------------
Fix it, then Ship it! Fix the few comments and ship it. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java (line 219) <https://reviews.apache.org/r/43242/#comment179764> Comment on what is the expected results. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java (line 223) <https://reviews.apache.org/r/43242/#comment179762> Remove the space. sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java (line 225) <https://reviews.apache.org/r/43242/#comment179761> Alignment. - Hao Hao On Feb. 9, 2016, 11:59 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43242/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2016, 11:59 p.m.) > > > Review request for sentry and Gregory Chanan. > > > Repository: sentry > > > Description > ------- > > Group names are case sensitive, handle them as such Generic model > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > e1c15fa5304b553f69ef4d7e5053d587efb92ae5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > 78d38473f938b1aa2b357dd858b00f833147ee5d > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java > f1a87a83a97f3e2d7d06462abaaf4b983ab17677 > > Diff: https://reviews.apache.org/r/43242/diff/ > > > Testing > ------- > > Existing tests pass, and also added a new test. > > > Thanks, > > Sravya Tirukkovalur > >
