I just join this community, Please I need some information about Sentry
architect or the class design.
Gus
On 2016-02-13 8:42 PM, Colin Ma wrote:
On Feb. 2, 2016, 7:21 a.m., Dapeng Sun wrote:
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Model.java,
line 22
<https://reviews.apache.org/r/42287/diff/3/?file=1225563#file1225563line22>
Nit: how about PrivilegeModel.
Actually I want to add more method for validation in this Class. For example,
validate the resource name, check the existence, etc. So this class is for the
model for component, not only for privilege.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42287/#review117353
-----------------------------------------------------------
On Feb. 6, 2016, 2:14 a.m., Colin Ma wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42287/
-----------------------------------------------------------
(Updated Feb. 6, 2016, 2:14 a.m.)
Review request for sentry.
Repository: sentry
Description
-------
Create CommonPrivilege for every component.
The main change is for the interface Privilege, implies(Privilege p) --->
implies(Privilege privilege, Map<String, String> implyMethodMap, Map<String,
Integer> actionMap)
The actionMap is stored the mapping between action name and action value, eg:
for Hive: select ---> 1 (binary: 0000001)
insert ---> 3 (binary: 0000011)
create ---> 4 (binary: 0000100)
all ---> 7 (binary: 0000111)
when compare the action, use the action value with the & operator
The implyMethodMap is stored the mapping between resource type and imply
method, eg:
for Hive: db ---> string (imply as string value)
url ---> url (imply as url value)
Diffs
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BitFieldAction.java
ce0e4fb
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ImplyMethodType.java
PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Model.java
PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Resource.java
PRE-CREATION
sentry-policy/sentry-policy-common/pom.xml fbec06f
sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java
PRE-CREATION
sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyConstants.java
0bad8c1
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/ModelForTest.java
PRE-CREATION
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestCommonPrivilege.java
PRE-CREATION
sentry-policy/sentry-policy-common/src/test/java/org/apache/sentry/policy/common/TestKeyValue.java
2dfc7c5
Diff: https://reviews.apache.org/r/42287/diff/
Testing
-------
Thanks,
Colin Ma
