> On 二月 29, 2016, 2:28 p.m., Dapeng Sun wrote: > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/HivePrivilegeModel.java, > > line 64 > > <https://reviews.apache.org/r/44056/diff/1/?file=1271842#file1271842line64> > > > > How about make the method as a part of Model or make it static? > > Colin Ma wrote: > I plan to add this method to Model later, so it isn't marked as static. I > think we can improve this after the whole refactor is finished.
SGTM - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44056/#review121191 ----------------------------------------------------------- On 二月 26, 2016, 1:53 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44056/ > ----------------------------------------------------------- > > (Updated 二月 26, 2016, 1:53 p.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1104 > https://issues.apache.org/jira/browse/SENTRY-1104 > > > Repository: sentry > > > Description > ------- > > Add method in Privilege model to create privilege validators > > > Diffs > ----- > > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/HivePrivilegeModel.java > f2cc77f > > sentry-core/sentry-core-model-indexer/src/main/java/org/apache/sentry/core/model/indexer/IndexerPrivilegeModel.java > be15dec > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchPrivilegeModel.java > 8231f12 > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopPrivilegeModel.java > 8c4307c > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/SimpleDBPolicyEngine.java > 7cbeb21 > > sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/SimpleIndexerPolicyEngine.java > 20985eb > > sentry-policy/sentry-policy-search/src/main/java/org/apache/sentry/policy/search/SimpleSearchPolicyEngine.java > 352e4aa > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java > 4a0012b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SolrTSentryPrivilegeConvertor.java > 75a6986 > > Diff: https://reviews.apache.org/r/44056/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
