-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43892/
-----------------------------------------------------------

(Updated Feb. 29, 2016, 6:36 p.m.)


Review request for sentry, Dapeng Sun and Hao Hao.


Changes
-------

Address review comments.


Bugs: SENTRY-1030
    https://issues.apache.org/jira/browse/SENTRY-1030


Repository: sentry


Description
-------

SENTRY-1030: Restrict Kafka Cluster authorizable to only have kafka-cluster as 
authorizable's name.

NOTE that this also includes changes from SENTRY-1056 and SENTRY-1098. I will 
rebase once those two are committed.


Diffs (updated)
-----

  
sentry-core/sentry-core-model-kafka/src/main/java/org/apache/sentry/core/model/kafka/Cluster.java
 bb30b1b78d4dccaf8ea5fe22eeed496b608cfcb1 
  
sentry-core/sentry-core-model-kafka/src/test/java/org/apache/sentry/core/model/kafka/TestKafkaAuthorizable.java
 20d5e8e518cb91b32fad930e9d39400764f40b55 
  
sentry-policy/sentry-policy-kafka/src/main/java/org/apache/sentry/policy/kafka/KafkaModelAuthorizables.java
 f1ed0001883e5d4b362389c258f4f72697a1e5a4 
  
sentry-policy/sentry-policy-kafka/src/test/java/org/apache/sentry/policy/kafka/TestKafkaModelAuthorizables.java
 513c2719424f994e8eb773e72073401b465b7d58 
  
sentry-policy/sentry-policy-kafka/src/test/java/org/apache/sentry/policy/kafka/provider/TestKafkaAuthorizationProviderGeneralCases.java
 bcc119860860d928d092ed3ddc0a5a28e841c9aa 

Diff: https://reviews.apache.org/r/43892/diff/


Testing
-------

Ran unit tests.


Thanks,

Ashish Singh

Reply via email to