> On March 8, 2016, 12:49 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ConfServlet.java, > > line 42 > > <https://reviews.apache.org/r/44400/diff/2/?file=1282195#file1282195line42> > > > > Add a test case for it?
sure. Will update a new diff - Li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44400/#review122431 ----------------------------------------------------------- On March 7, 2016, 4:40 a.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44400/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 4:40 a.m.) > > > Review request for sentry, Anne Yu, Hao Hao, Lenni Kuff, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Add servlet for dumping configurations > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/ConfServlet.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 9778c963c023244adfe4c0299ee1b372b1eddbc7 > sentry-provider/sentry-provider-db/src/main/webapp/SentryService.html > f63097307f8359e650d9742d35a4683bec14a894 > > Diff: https://reviews.apache.org/r/44400/diff/ > > > Testing > ------- > > > Thanks, > > Li Li > >
