Author: rhuijben
Date: Sat Oct 17 12:25:14 2015
New Revision: 1709150

URL: http://svn.apache.org/viewvc?rev=1709150&view=rev
Log:
Merge:
 * r1699986, r1699987
   Fix types of some currently unused batons
   Justification:
     Without proper types these typing errors make debugging harder
     than necessary.
   Votes:
     +1: rhuijben, ivan

Modified:
    serf/branches/1.3.x/   (props changed)
    serf/branches/1.3.x/STATUS
    serf/branches/1.3.x/context.c
    serf/branches/1.3.x/outgoing.c

Propchange: serf/branches/1.3.x/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sat Oct 17 12:25:14 2015
@@ -1,4 +1,4 @@
 /serf/branches/1.3.x:1699925,1699931
 /serf/branches/multiple_ssl_impls:1699382
 /serf/branches/windows-sspi:1698866-1698877
-/serf/trunk:1699516-1699518,1699520-1699522,1699528,1699530-1699535,1699537,1699539-1699543,1699548-1699549,1699553,1699555-1699556,1699559-1699560,1699563-1699565,1699567-1699570,1699572-1699573,1699578-1699580,1699582-1699597,1699599-1699602,1699607,1699610,1699615-1699618,1699622-1699623,1699626-1699627,1699633,1699637,1699642,1699645,1699647,1699649-1699650,1699652,1699654-1699655,1699659-1699665,1699671,1699674,1699680-1699683,1699687-1699688,1699690,1699692-1699694,1699698-1699700,1699702,1699707-1699708,1699712-1699716,1699720,1699724,1699728,1699730,1699733,1699762,1699770,1699773,1699777,1699780-1699781,1699791,1699798,1699800-1699801,1699817,1699819,1699838,1699843,1699846,1699850,1699858-1699859,1699861,1699873,1699881,1699884,1699902-1699903,1699906,1699924,1699926-1699927,1699930,1699932,1699936-1699937,1699941,1699944,1699948-1699950,1699954,1699957,1699964,1699973,1699975,1699985,1699993-1699994,1700062,1700128,1700149,1700234,1700236,1700246,1700270,1700650,1700830,1
 702096,1702221,1702264,1708849
+/serf/trunk:1699516-1699518,1699520-1699522,1699528,1699530-1699535,1699537,1699539-1699543,1699548-1699549,1699553,1699555-1699556,1699559-1699560,1699563-1699565,1699567-1699570,1699572-1699573,1699578-1699580,1699582-1699597,1699599-1699602,1699607,1699610,1699615-1699618,1699622-1699623,1699626-1699627,1699633,1699637,1699642,1699645,1699647,1699649-1699650,1699652,1699654-1699655,1699659-1699665,1699671,1699674,1699680-1699683,1699687-1699688,1699690,1699692-1699694,1699698-1699700,1699702,1699707-1699708,1699712-1699716,1699720,1699724,1699728,1699730,1699733,1699762,1699770,1699773,1699777,1699780-1699781,1699791,1699798,1699800-1699801,1699817,1699819,1699838,1699843,1699846,1699850,1699858-1699859,1699861,1699873,1699881,1699884,1699902-1699903,1699906,1699924,1699926-1699927,1699930,1699932,1699936-1699937,1699941,1699944,1699948-1699950,1699954,1699957,1699964,1699973,1699975,1699985-1699987,1699993-1699994,1700062,1700128,1700149,1700234,1700236,1700246,1700270,1700650,1
 700830,1702096,1702221,1702264,1708849

Modified: serf/branches/1.3.x/STATUS
URL: 
http://svn.apache.org/viewvc/serf/branches/1.3.x/STATUS?rev=1709150&r1=1709149&r2=1709150&view=diff
==============================================================================
--- serf/branches/1.3.x/STATUS (original)
+++ serf/branches/1.3.x/STATUS Sat Oct 17 12:25:14 2015
@@ -11,14 +11,6 @@ Status of 1.3.9:
 Candidate changes:
 ==================
 
- * r1699986, r1699987
-   Fix types of some currently unused batons
-   Justification:
-     Without proper types these typing errors make debugging harder
-     than necessary.
-   Votes:
-     +1: rhuijben, ivan
-
  * r1699852
    Fix incorrect use of bio file handlers (r1699852)
    Votes:

Modified: serf/branches/1.3.x/context.c
URL: 
http://svn.apache.org/viewvc/serf/branches/1.3.x/context.c?rev=1709150&r1=1709149&r2=1709150&view=diff
==============================================================================
--- serf/branches/1.3.x/context.c (original)
+++ serf/branches/1.3.x/context.c Sat Oct 17 12:25:14 2015
@@ -217,7 +217,7 @@ apr_status_t serf_event_trigger(
             tdesc.desc.s = conn->skt;
             tdesc.reqevents = conn->reqevents;
             ctx->pollset_rm(ctx->pollset_baton,
-                            &tdesc, conn);
+                            &tdesc, &conn->baton);
             return conn->status;
         }
         /* apr_pollset_poll() can return a conn multiple times... */
@@ -238,7 +238,7 @@ apr_status_t serf_event_trigger(
                 tdesc.desc.s = conn->skt;
                 tdesc.reqevents = conn->reqevents;
                 ctx->pollset_rm(ctx->pollset_baton,
-                                &tdesc, conn);
+                                &tdesc, &conn->baton);
             }
             return conn->status;
         }
@@ -300,9 +300,9 @@ apr_status_t serf_context_run(
     }
 
     while (num--) {
-        serf_connection_t *conn = desc->client_data;
+        serf_io_baton_t *io  = desc->client_data;
 
-        status = serf_event_trigger(ctx, conn, desc);
+        status = serf_event_trigger(ctx, io, desc);
         if (status) {
             return status;
         }

Modified: serf/branches/1.3.x/outgoing.c
URL: 
http://svn.apache.org/viewvc/serf/branches/1.3.x/outgoing.c?rev=1709150&r1=1709149&r2=1709150&view=diff
==============================================================================
--- serf/branches/1.3.x/outgoing.c (original)
+++ serf/branches/1.3.x/outgoing.c Sat Oct 17 12:25:14 2015
@@ -147,7 +147,7 @@ apr_status_t serf__conn_update_pollset(s
     desc.reqevents = conn->reqevents;
 
     status = ctx->pollset_rm(ctx->pollset_baton,
-                             &desc, conn);
+                             &desc, &conn->baton);
     if (status && !APR_STATUS_IS_NOTFOUND(status))
         return status;
 
@@ -552,7 +552,7 @@ static apr_status_t remove_connection(se
     desc.reqevents = conn->reqevents;
 
     return ctx->pollset_rm(ctx->pollset_baton,
-                           &desc, conn);
+                           &desc, &conn->baton);
 }
 
 /* A socket was closed, inform the application. */


Reply via email to