On 28. 5. 25 21:32, James McCoy wrote:
On Wed, May 28, 2025 at 07:00:56PM +0000, br...@apache.org wrote:
Modified: serf/trunk/CMakeLists.txt
URL: http://svn.apache.org/viewvc/serf/trunk/CMakeLists.txt?rev=1925911&r1=1925910&r2=1925911&view=diff ==============================================================================
--- serf/trunk/CMakeLists.txt (original)
+++ serf/trunk/CMakeLists.txt Wed May 28 19:00:56 2025
@@ -401,12 +401,12 @@ if(NOT SERF_WINDOWS)
    foreach(DEPLIB ${SERF_INTERFACE_LIBS})
      string(APPEND LIBS " ${DEPLIB}")
    endforeach()
-    configure_file("build/serf.pc.in" "serf.pc" @ONLY)
+    configure_file("build/serf.pc.in" "serf-${SERF_MAJOR_VERSION}.pc" @ONLY)
  endfunction()

  make_pkgconfig()
-  install(FILES "${CMAKE_CURRENT_BINARY_DIR}/serf.pc"
-          DESTINATION "share/pkgconfig")
+  install(FILES "${CMAKE_CURRENT_BINARY_DIR}/serf-${SERF_MAJOR_VERSION}.pc"
+          DESTINATION "lib/pkgconfig")

These install directives should likely use the GNUInstallDirs-specified
directory, so that distributions have a common mechanism to adjust it.
For example, Debian installs these to architecture specific paths like
/usr/lib/x86_64-linux-gnu/pkgconfig/.

include(GNUInstallDirs)
install(FILES "${CMAKE_CURRENT_BINARY_DIR}/serf-${SERF_MAJOR_VERSION}.pc"
        DESTINATION "${CMAKE_INSTALL_LIBDIR}/pkgconfig")

Oh, thanks, I'll change this. I wonder if SCons has anything similar? Will have to check.

-- Brane

Reply via email to