Hi!

With the latest bunch of commits, I'm tentatively hopeful that the CMake build is now on par with the SCons build. But it needs a lot of testing and review.

One part where I'm a bit baffled is generating the pkg-config file. The more I look at it, the more it seems like the library list is either too long or incomplete, and the structure is inconsistent. It'd save me a lot of grief if someone more knowledgeable could have a look at that...

I'm also unsure if we should generate a serf-config.cmake for downstream consumers, and where to install it if we do. CMake docs are less than specific, bit something like $prefix/lib/cmake/ or $prefix/share/cmake seems to be right for Unix, and just $preifx/cmake for Windows.

Anyway. I tested this on two platforms:

 * arm64 macOS, with both Homebrew and MacPorts dependencies:
     o with Homebrew, I used the default system zlib
     o there is a system GSSAPI but if I use it, the tests go into an
       infinite loop
 * arm64 Windows, using MSBuild (with Visual Studio) and vcpkg for
   dependencies. Nothing very special there except that the Windows VM
   is horribly slow.

I didn't test with APR trunk (apr-2), perhaps I should. It's at least theoretically supported, and I'm sure it worked at one time, but I'll have to build that first.

So, any and all feedback welcome.

-- Brane

P.S.: No, I am *not* a CMake maestro. I keep a browser window with cmake-3.12 docs open and that's pretty much it. I'm sure some things could be done more modernly CMake-ish.

Reply via email to