Author: brane
Date: Thu Jun 19 02:45:53 2025
New Revision: 1926566
URL: http://svn.apache.org/viewvc?rev=1926566&view=rev
Log:
Went through the code with a -pedantic comb and removed the C99-isms.
Turns out they were all trailing commas in enum declarations.
What follows is just a list of changed enums; the trailing comma
was removed in all the cases
* serf.h (serf_config_categories_t).
* serf_private.h (serf_request_writing_t, serf__connection_state_t).
* auth/auth_spnego.c (gss_api_auth_state, authn_persistence_state_t).
* buckets/deflate_buckets.c (deflate_context_t).
* buckets/fcgi_buckets.c (fcgi_params_decode_ctx_t).
* buckets/ssl_buckets.c (san_copy_t).
Modified:
serf/trunk/auth/auth_spnego.c
serf/trunk/buckets/deflate_buckets.c
serf/trunk/buckets/fcgi_buckets.c
serf/trunk/buckets/ssl_buckets.c
serf/trunk/serf.h
serf/trunk/serf_private.h
Modified: serf/trunk/auth/auth_spnego.c
URL:
http://svn.apache.org/viewvc/serf/trunk/auth/auth_spnego.c?rev=1926566&r1=1926565&r2=1926566&view=diff
==============================================================================
--- serf/trunk/auth/auth_spnego.c (original)
+++ serf/trunk/auth/auth_spnego.c Thu Jun 19 02:45:53 2025
@@ -99,7 +99,7 @@
typedef enum gss_api_auth_state {
gss_api_auth_not_started,
gss_api_auth_in_progress,
- gss_api_auth_completed,
+ gss_api_auth_completed
} gss_api_auth_state;
/**
@@ -159,7 +159,7 @@ typedef enum authn_persistence_state_t {
pstate_init,
pstate_undecided,
pstate_stateless,
- pstate_stateful,
+ pstate_stateful
} authn_persistence_state_t;
Modified: serf/trunk/buckets/deflate_buckets.c
URL:
http://svn.apache.org/viewvc/serf/trunk/buckets/deflate_buckets.c?rev=1926566&r1=1926565&r2=1926566&view=diff
==============================================================================
--- serf/trunk/buckets/deflate_buckets.c (original)
+++ serf/trunk/buckets/deflate_buckets.c Thu Jun 19 02:45:53 2025
@@ -56,7 +56,7 @@ typedef struct deflate_context_t {
/* When handling things the other way around */
STATE_WRITING_HEADER, /* produces a gzip header */
STATE_COMPRESS_INIT, /* initializes zlib for compression */
- STATE_COMPRESS_FINISH, /* clean up after producing body */
+ STATE_COMPRESS_FINISH /* clean up after producing body */
} state;
z_stream zstream;
Modified: serf/trunk/buckets/fcgi_buckets.c
URL:
http://svn.apache.org/viewvc/serf/trunk/buckets/fcgi_buckets.c?rev=1926566&r1=1926565&r2=1926566&view=diff
==============================================================================
--- serf/trunk/buckets/fcgi_buckets.c (original)
+++ serf/trunk/buckets/fcgi_buckets.c Thu Jun 19 02:45:53 2025
@@ -282,7 +282,7 @@ typedef struct fcgi_params_decode_ctx_t
{
DS_SIZES = 0,
DS_KEY,
- DS_VALUE,
+ DS_VALUE
} state;
char size_buffer[8];
@@ -906,4 +906,3 @@ const serf_bucket_type_t serf_bucket_typ
serf_fcgi_frame_get_remaining,
serf_fcgi_frame_set_config
};
-
Modified: serf/trunk/buckets/ssl_buckets.c
URL:
http://svn.apache.org/viewvc/serf/trunk/buckets/ssl_buckets.c?rev=1926566&r1=1926565&r2=1926566&view=diff
==============================================================================
--- serf/trunk/buckets/ssl_buckets.c (original)
+++ serf/trunk/buckets/ssl_buckets.c Thu Jun 19 02:45:53 2025
@@ -725,7 +725,7 @@ static int ocsp_callback(SSL *ssl, void
typedef enum san_copy_t {
EscapeNulAndCopy = 0,
- ErrorOnNul = 1,
+ ErrorOnNul = 1
} san_copy_t;
Modified: serf/trunk/serf.h
URL:
http://svn.apache.org/viewvc/serf/trunk/serf.h?rev=1926566&r1=1926565&r2=1926566&view=diff
==============================================================================
--- serf/trunk/serf.h (original)
+++ serf/trunk/serf.h Thu Jun 19 02:45:53 2025
@@ -1362,7 +1362,7 @@ typedef const apr_uint32_t serf_config_k
typedef enum serf_config_categories_t {
SERF_CONFIG_PER_CONTEXT = 0x10000000,
SERF_CONFIG_PER_HOST = 0x20000000,
- SERF_CONFIG_PER_CONNECTION = 0x40000000,
+ SERF_CONFIG_PER_CONNECTION = 0x40000000
} serf_config_categories_t;
#define SERF_CONFIG_HOST_NAME (SERF_CONFIG_PER_HOST | 0x000001)
Modified: serf/trunk/serf_private.h
URL:
http://svn.apache.org/viewvc/serf/trunk/serf_private.h?rev=1926566&r1=1926565&r2=1926566&view=diff
==============================================================================
--- serf/trunk/serf_private.h (original)
+++ serf/trunk/serf_private.h Thu Jun 19 02:45:53 2025
@@ -232,7 +232,7 @@ typedef enum serf_request_writing_t {
SERF_WRITING_NONE, /* Nothing written */
SERF_WRITING_STARTED, /* Data in write bucket(s) */
SERF_WRITING_DONE, /* Everything written */
- SERF_WRITING_FINISHED, /* Safe to destroy */
+ SERF_WRITING_FINISHED /* Safe to destroy */
} serf_request_writing_t;
/* Holds all the information corresponding to a request/response pair. */
@@ -518,7 +518,7 @@ struct serf_incoming_t {
typedef enum {
SERF_CONN_INIT, /* no socket created yet */
SERF_CONN_SETUP_SSLTUNNEL, /* ssl tunnel being setup, no requests sent */
- SERF_CONN_CONNECTED, /* conn is ready to send requests */
+ SERF_CONN_CONNECTED /* conn is ready to send requests */
} serf__connection_state_t;
struct serf_connection_t {
