Strange bit of code in Serf hpack_buckets.c

[Branko Čibej]

Hi Bert,

I've been going through the Serf code on trunk, trying to fix compiler 
warnings, and found something that I don't understand and don't want to 
just "fix" and possibly introduce a bug. I'm asking for your help, as 
you're the author of that code:

https://svn.apache.org/viewvc/serf/trunk/buckets/hpack_buckets.c?annotate=1926128#l1393


I see a warning that 'status' is assigned but never used, and indeed 
that's the case; here is the assignment, on line 1479:

    if (ctx->reuse_item)
    {
        status = hpack_table_get(ctx->reuse_item, tbl,
                                 &keep_key, NULL,
                                 &keep_val, NULL);
    }


and the return value is just ignored, even though hpack_table_get() can 
return an error. I don't know enough to make a safe decision, but just 
removing the assignment and 'status' seems wrong.

I know it's been a long time since you wrote this. Still, do you have 
any suggestions?

Thanks!

-- Brane