Den tors 1 jan. 2026 kl 18:33 skrev <[email protected]>:

> Author: brane
> Date: Thu Jan  1 17:33:48 2026
> New Revision: 1931046
>
>
...


>    Use OSSL_STORE_open() instead of the _ex() variant because we don't
>    use any of the extended parameters.
>

...


>  #if defined(SERF_HAVE_OSSL_STORE_OPEN_EX)
>

...


> -        store = OSSL_STORE_open_ex(cert_uri, NULL, NULL, ui_method, ctx,
> NULL,
> -                                   NULL, NULL);
> +        store = OSSL_STORE_open(cert_uri, ui_method, ctx, NULL, NULL);
>

Does it make sense to also re-name the define (and obviously also change
the feature detection in SConstruct/CMakeList.txt)? As far as I can tell,
the other functions that are used protected by this #ifdef should be
available whenever OSSL_STORE_open is available.

In practice this means we would support the OSSL_STORE functions even with
OpenSSL 1.1 (OSSL_STORE_open_ex appeared in 3.0). On the other hand, nobody
should be using such an old version anyway...

Cheers,
Daniel

Reply via email to