So I added this and linked from SERF-208. I think removing the FIXME's is a blocker (not that it is very difficult), except possibly the TODO.
/Daniel Den sön 4 jan. 2026 kl 22:42 skrev Daniel Sahlberg (Jira) <[email protected]>: > Daniel Sahlberg created SERF-211: > ------------------------------------ > > Summary: Finalise async resolver > Key: SERF-211 > URL: https://issues.apache.org/jira/browse/SERF-211 > Project: serf > Issue Type: Bug > Reporter: Daniel Sahlberg > > > The async resolver code contains a bunch of FIXMEs: > > > > resolve.c > > /* > * FIXME: EXPERIMENTAL > * TODO: > * - Wake the poll/select in serf_context_run() when new resolve > * results are available. > */ > > > > init_once.c > > /* FIXME: Do we really want to support APR-0.9.x? */ > {color:#FF0000}(no?){color} > > return APR_EGENERAL; /* FIXME: Just abort()? */ {color:#FF0000}(as the > previous comment says: It can't happen, was there some stupid compiler > complaining?){color} > > > > serf.h > > /* FIXME: EXPERIMENTAL */ > > (four times, on the declarations of the async functions/callbacks) > > > > > > > > -- > This message was sent by Atlassian Jira > (v8.20.10#820010) >
